Complete GNU Taler refund lifecycle#14
Open
roncodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the human-usable GNU Taler refund lifecycle in Ledger. It makes Taler refund URIs persistent and customer-facing, adds refund history and email delivery, exposes a public wallet handoff page, and adds scheduled refund verification so invoices only progress from pending refund states once the Taler wallet has picked up the refund.
What Changed
refund_pendingorpartial_refund_pendinguntil wallet acceptance is confirmed.ledger:taler:verify-refunds, scheduled every 15 minutes, to poll Taler Merchant Backend order status usingrefund_pending,refund_taken, and cumulative refund amounts.Validation
php -lpassed for touched PHP files.npx eslint addon/controllers/billing/invoices/index/details.js addon/components/modals/refund-history.jspassed.npm run lint:hbs -- addon/components/modals/refund-history.hbs addon/components/modals/refund-result.hbs addon/components/customer-taler-refund.hbs addon/components/customer-invoice.hbsexited successfully, with the existingno-down-event-bindingconfiguration warning still printed.git diff --checkpassed.Unable to find Pest. Run composer install first.Notes
The scheduler is intentionally no-op friendly: if no active Taler gateways or pending Taler refunds exist, it exits cleanly. The command can also be run manually with
php artisan ledger:taler:verify-refundsor scoped to one refund with--refund=<gateway_transaction_id>.